Add migration to fix data_store ids #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeepc
reviewed
Apr 27, 2023
|
|
||
| UPDATE data_stores | ||
| SET id = 'current' | ||
| WHERE id = (select id from data_stores order by created_at limit 1); |
There was a problem hiding this comment.
Shouldn't we get the one with is_default = true ?
There was a problem hiding this comment.
🤦 sure! changing it!
There was a problem hiding this comment.
query updated to consider is_default
mathnogueira
approved these changes
Apr 27, 2023
schoren
pushed a commit
that referenced
this pull request
Jun 5, 2023
* Add migration to fix data_store ids * Adding PR suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a server migration to guarantee that preexisting data_stores will continue working on Tracetest.
Changes
Checklist