Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix connecting to datastores docs #2466

Merged
merged 1 commit into from May 2, 2023
Merged

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented May 1, 2023

This PR adds some fixes for the Connection to DataStores section in our docs.

Changes

  • Fix datastore types

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@jorgeepc jorgeepc self-assigned this May 1, 2023
@jorgeepc jorgeepc added the documentation Improvements or additions to documentation label May 1, 2023
Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -86,8 +86,8 @@ Or, if you prefer using the CLI, you can use this file config.
```yaml
type: DataStore
spec:
name: Opentelemetry Collector pipeline
type: otlp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@jorgeepc jorgeepc merged commit 60f0b68 into main May 2, 2023
1 check passed
@jorgeepc jorgeepc deleted the fix-docs-datastores branch May 2, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants