Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: adding honeycomb datastore support #2471

Merged
merged 9 commits into from May 3, 2023
Merged

feature: adding honeycomb datastore support #2471

merged 9 commits into from May 3, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented May 2, 2023 •
edited

This PR adds support for Honeycomb as data store

Changes

  • Adds honeycomb support for both BE, FE and CLI
  • Adds recipe page for honeycomb
  • Adds tracetest x honeycomb example

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

https://www.loom.com/share/e6eb3ffdc0a0490792e8220dac29bff2

@xoscar xoscar linked an issue May 2, 2023 that may be closed by this pull request
Add honeycomb.io support as data store #1945
Closed
@xoscar xoscar marked this pull request as ready for review May 2, 2023 16:22
@xoscar xoscar changed the title feature: dding honeycomb otel collector support feature: adding honeycomb datastore support May 2, 2023
jorgeepc
jorgeepc approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@jorgeepc jorgeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @xoscar, added a couple of comments

docs/docs/examples-tutorials/recipes/running-tracetest-with-honeycomb.md Outdated Show resolved Hide resolved
docs/docs/examples-tutorials/recipes/running-tracetest-with-honeycomb.md Show resolved Hide resolved
examples/tracetest-honeycomb/readme.md Outdated Show resolved Hide resolved
examples/tracetest-honeycomb/readme.md Outdated Show resolved Hide resolved
@xoscar xoscar merged commit dc54316 into main May 3, 2023
28 checks passed
@xoscar xoscar deleted the 1945-add-honeycombio-support-as-data-store branch May 3, 2023 03:46
schoren pushed a commit that referenced this pull request Jun 5, 2023
@xoscar @schoren
feature: adding honeycomb datastore support (#2471)
f2f67b4 
* feature: adding honeycomb otel collector support

* feature: adding honeycomb otel collector support

* feature: adding honeycomb connection docs

* PR comments

* adding identation

* adding identation

* fixing bash script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

@schoren schoren Awaiting requested review from schoren

@danielbdias danielbdias Awaiting requested review from danielbdias

@kdhamric kdhamric Awaiting requested review from kdhamric

@mathnogueira mathnogueira Awaiting requested review from mathnogueira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add honeycomb.io support as data store
2 participants
@xoscar @jorgeepc