Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installer): updating grpc host when installing the docker version with pokeshop #2485

Merged
merged 1 commit into from May 4, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented May 4, 2023

This PR fixes the hostname for the demo rpc endpoint when installing tracetest using docker and the pokeshop demo

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar xoscar added the backend label May 4, 2023
@xoscar xoscar requested a review from jorgeepc May 4, 2023 17:41
@xoscar xoscar self-assigned this May 4, 2023
@xoscar xoscar marked this pull request as ready for review May 4, 2023 17:41
@xoscar xoscar merged commit 0cba51d into main May 4, 2023
28 checks passed
@xoscar xoscar deleted the fix/docker-pokeshop-grpc-tests branch May 4, 2023 18:02
schoren pushed a commit that referenced this pull request May 9, 2023
schoren pushed a commit that referenced this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants