feat(frontend): migrate transactions to resource architecture #2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeepc
force-pushed
the
2358-transactions-to-resource-fe
branch
from
434651c
to
cf183f0
Compare
jorgeepc
changed the title
schoren
force-pushed
the
feat/transactions-as-resources
branch
from
f810cf8
to
0d2c098
Compare
xoscar
reviewed
May 19, 2023
| $ref: "./grpc.yaml#/components/schemas/GRPCRequest" | ||
| traceid: | ||
| $ref: "./traceid.yaml#/components/schemas/TRACEIDRequest" | ||
| http: |
There was a problem hiding this comment.
There's a mismatch between the resource version and the regular version, I removed the triggerSettings to have them both work the same
xoscar
reviewed
May 19, 2023
| Http: m.HTTPRequest(in.HTTP), | ||
| Grpc: m.GRPCRequest(in.GRPC), | ||
| Traceid: m.TRACEIDRequest(in.TraceID), | ||
| }, |
xoscar
reviewed
May 19, 2023
| @@ -66,7 +66,7 @@ func (t Transaction) NewRun() TransactionRun { | |||
| return TransactionRun{ | |||
| TransactionID: t.ID, | |||
| TransactionVersion: t.GetVersion(), | |||
| CreatedAt: time.Now(), | |||
| CreatedAt: time.Now().UTC(), | |||
There was a problem hiding this comment.
This was a bug, we need to always use UTC from the server
xoscar
reviewed
May 19, 2023
| return Transaction.FromRawTransaction(rawTransaction); | ||
| } | ||
|
|
||
| Transaction.FromRawTransaction = ({ |
There was a problem hiding this comment.
Currently, we have to support two versions of the transactions API object:
- resource (from the resource endpoints)
- regular raw version (from the result list home page)
xoscar
reviewed
May 19, 2023
| import TransactionService from 'services/Transaction.service'; | ||
| import {TTestApiEndpointBuilder} from 'types/Test.types'; | ||
| import {TDraftTransaction} from 'types/Transaction.types'; | ||
|
|
||
| const defaultHeaders = {'content-type': 'application/json', 'X-Tracetest-Augmented': 'true'}; |
There was a problem hiding this comment.
Including the augmented header
There was a problem hiding this comment.
not sure how this works, but just to be safe: for requesting the yaml definition, you need to NOT pass the header.
There was a problem hiding this comment.
Yep we have that covered 😄
schoren
approved these changes
May 19, 2023
xoscar
merged commit 9813abb
into
feat/transactions-as-resources
21 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the FE to work with the new transactions as resources BE changes
Changes
triggerSettingsobject for triggersFixes
Checklist