fix(cli): fixing nested structs output format #2496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
requested review from
danielbdias,
schoren,
mathnogueira and
jorgeepc
and removed request for
danielbdias
jorgeepc
approved these changes
May 5, 2023
schoren
approved these changes
May 5, 2023
danielbdias
approved these changes
May 5, 2023
schoren
pushed a commit
that referenced
this pull request
May 9, 2023
schoren
pushed a commit
that referenced
this pull request
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue we had when parsing YAML strings into structs when having nested structures similar to the Demo.
When parsing the Demo objects the values for the pokeshop and the open telemetry store objects were empty.
In this case, we are now using the open API provided logic to unmarshal JSON bytes into structs.
Changes
Checklist
Wrong output:
Fixed output:
