Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: block fe analytics if TRACETEST_DEV is present #2503

Merged
merged 1 commit into from
May 10, 2023
Merged

fix: block fe analytics if TRACETEST_DEV is present #2503

merged 1 commit into from
May 10, 2023

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented May 9, 2023

This PR fixes an issue to prevent the webApp to send analytics (segment & posthog) when the TRACETEST_DEV variable is present

Changes

  • fix fe analytics when TRACETEST_DEV is present

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@jorgeepc jorgeepc self-assigned this May 9, 2023
@jorgeepc jorgeepc marked this pull request as ready for review May 9, 2023 07:05
@jorgeepc jorgeepc merged commit 759a323 into main May 10, 2023
31 checks passed
@jorgeepc jorgeepc deleted the fix-fe-tracetestDev branch May 10, 2023 05:29
@danielbdias danielbdias mentioned this pull request May 30, 2023
Closed
schoren pushed a commit that referenced this pull request Jun 5, 2023
@jorgeepc @schoren
fix: block fe analytics if TRACETEST_DEV is present (#2503)
1268a6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoscar xoscar xoscar approved these changes

@danielbdias danielbdias danielbdias approved these changes

Assignees

@jorgeepc jorgeepc

Labels
backend frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jorgeepc @xoscar @danielbdias