Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): highlight selected span #2504

Merged
merged 1 commit into from
May 12, 2023
Merged

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented May 9, 2023

In our current graph view, we highlight the selected span by using a blue line around the span. However, it is not easy no identify it specially when you are in the "Test Spec" detail mode. This PR improves this design to have a clear understanding of which span is selected.

Changes

  • Improve selected span in graph view

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Screenshots

Screenshot 2023-05-09 at 16 00 05

Screenshot 2023-05-09 at 15 59 51

@jorgeepc jorgeepc self-assigned this May 9, 2023
@jorgeepc jorgeepc merged commit c47f431 into main May 12, 2023
28 checks passed
@jorgeepc jorgeepc deleted the 2495-fix-selected-span branch May 12, 2023 13:51
schoren pushed a commit that referenced this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight selected span
2 participants