Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(cli): version display improvements #2505

Merged

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented May 9, 2023

This PR adds a way for users to see what is the CLI and the server versions they are trying to use, this way if something isn't working correctly they can validate that before starting working.

It also shows the versions on every cmd error.

Changes

  • Adds new middleware to handle run command responses
  • Adds backend version endpoint
  • Updates version command
  • Setup command now loads the version in memory

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Correct response
Screenshot 2023-05-09 at 17 39 25

Server not configured
Screenshot 2023-05-09 at 17 39 40

Server wrong response
Screenshot 2023-05-09 at 17 39 53

Failed command
Screenshot 2023-05-09 at 17 40 31

@xoscar xoscar self-assigned this May 9, 2023
@xoscar xoscar linked an issue May 9, 2023 that may be closed by this pull request
@xoscar xoscar marked this pull request as ready for review May 9, 2023 08:37
@xoscar xoscar merged commit e7dccae into main May 10, 2023
@xoscar xoscar deleted the 2296-cli-improvements-show-server-and-cli-version-when-possible branch May 10, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CLI Improvements] Show server and cli version when possible
2 participants