Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tracetesting): changing env file name to yaml to avoid confusion with dotfiles #2542

Merged
merged 12 commits into from May 26, 2023
Merged

fix(tracetesting): changing env file name to yaml to avoid confusion with dotfiles #2542

merged 12 commits into from May 26, 2023

Conversation

danielbdias
Copy link
Contributor

@danielbdias danielbdias commented May 15, 2023 •
edited

This PR updates the references of env file in our tracetesting cases to use yaml instead of .env.

Changes

  • Updated environment file name to explicitly that it is a .yaml file.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

mathnogueira and others added 11 commits May 22, 2023 14:02
@mathnogueira @danielbdias
fix environment encoding (#2543)
17fea54
@jorgeepc @danielbdias
fix(frontend): fix empty body and headers in trigger tab (#2540)
39c08d2
@schoren @danielbdias
[hackathon] kubectl trace based testing (#2549)
a3864e9 
* add script and basic docs

* Adding k3d setup docs

* finish script

* Adding containerd tracing to our Kube Tracing example

* add kubelet script

* add example

* Updating docs

* Update files

* Fix rebase error

* Removing file

---------

Co-authored-by: Daniel Dias <danielbpdias@gmail.com>
@jorgeepc @danielbdias
feat(server): add traceDB endpoints to event log (#2516)
b9839b2
@olange @danielbdias
Update docs/concepts/transactions: «Tests A, B» instead of «Tx A, B» (#…
077ce2f 
…2537)

Update concepts/transactions.md: «Tests A and B» instead of «Transactions A and B»
@jorgeepc @danielbdias
fix(docs): fix docs related to data stores (#2558)
8d326b0
@danielbdias @adnanrahic
Updating Kubernetes installation docs (#2562)
bfbbb2f 
* Updating Kubernetes installation docs

* Apply suggestions from code review

Co-authored-by: Adnan Rahić <adnan@kubeshop.io>

---------

Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
@danielbdias
Adding change to trigger CI
0b2a701
@danielbdias
Merge branch 'main' into fix/tracetest-env-formatting
e30995a
@danielbdias
Merge branch 'main' into fix/tracetest-env-formatting
91b0d39
@danielbdias
Merge branch 'main' into fix/tracetest-env-formatting
21124d3
@danielbdias danielbdias marked this pull request as ready for review May 26, 2023 15:31
@danielbdias danielbdias changed the title Changing env file name to yaml to avoid confusion with dotfiles chore(tracetesting): changing env file name to yaml to avoid confusion with dotfiles May 26, 2023
@danielbdias danielbdias changed the title chore(tracetesting): changing env file name to yaml to avoid confusion with dotfiles fix(tracetesting): changing env file name to yaml to avoid confusion with dotfiles May 26, 2023
@danielbdias danielbdias merged commit 05dc8dc into main May 26, 2023
27 checks passed
@danielbdias danielbdias deleted the fix/tracetest-env-formatting branch May 26, 2023 15:53
schoren pushed a commit that referenced this pull request Jun 5, 2023
@danielbdias @schoren
fix(tracetesting): changing env file name to yaml to avoid confusion …
f9a38f6 
…with dotfiles (#2542)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danielbdias @jorgeepc @mathnogueira @schoren @olange