Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Tracetest Analyzer Improvements #2628

Merged
merged 3 commits into from Jun 1, 2023
Merged

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Jun 1, 2023

This PR includes the Tracetest Analyzer improvements described in the parent ticket plus some fixes

Changes

  • Adds tab query param for settings
  • Updates linter test to the analyzer
  • Updates BE resource name
  • Fixes save analyzer settings bug

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

https://www.loom.com/share/d403016d171f4e898d0cdbb3bf39e55b

@xoscar xoscar linked an issue Jun 1, 2023 that may be closed by this pull request
@xoscar xoscar self-assigned this Jun 1, 2023
@xoscar xoscar marked this pull request as ready for review June 1, 2023 16:19
Copy link
Contributor

@jorgeepc jorgeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@xoscar xoscar merged commit 284d2bf into main Jun 1, 2023
28 checks passed
@xoscar xoscar deleted the 2626-linter-improvements branch June 1, 2023 17:37
@olha23
Copy link

olha23 commented Jun 2, 2023

cool, thanks for update

schoren pushed a commit that referenced this pull request Jun 5, 2023
* feature: Tracetest Analyzer Improvements

* feature: Tracetest Analyzer Improvements

* fix plugin names

---------

Co-authored-by: Jorge Padilla <jorge.esteban.padilla@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linter improvements
4 participants