Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(frontend): Adding Analyzer empty state #2642

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Jun 2, 2023

This PR adds the empty state for the analyzer results, only showing the results wheel when it was enabled during the test run execution.

Changes

  • Adds empty state for analyzer results
  • Moves analyzer results to their own folder
  • Improves code readability

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test
Screenshot 2023-06-02 at 12 04 47

@xoscar xoscar added the frontend label Jun 2, 2023
@xoscar xoscar self-assigned this Jun 2, 2023
@xoscar xoscar linked an issue Jun 2, 2023 that may be closed by this pull request
@xoscar xoscar marked this pull request as ready for review June 2, 2023 18:04
</S.SpanButton>
<div>
{result.errors.map(error => (
<div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a key prop here 🙈

@jorgeepc jorgeepc merged commit be3c75f into main Jun 2, 2023
27 checks passed
@jorgeepc jorgeepc deleted the 2633-avoid-showing-analyzer-results-when-i-disable-it-on-settings-page branch June 2, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid showing Analyzer results when I disable it on settings page
2 participants