fix: make sure temporary root span is not added to the trace if Tracetest Trigger span already exists #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathnogueira
force-pushed
the
fix/temporary-root-span
branch
from
3c531a5
to
06eaf13
Compare
xoscar
approved these changes
Jun 9, 2023
mathnogueira
added a commit
that referenced
this pull request
Jun 13, 2023
…test Trigger span already exists (#2657) * fix: temporary span showing up in final trace * improve conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new conditions on when to add the temporary root span in the trace. Now, if one of the root spans is the
Tracetest triggerspan, it gets promoted as the root span. This prevents the issue of having twoTracetest triggerspans in the same traceFixes
Checklist