fix(frontend): fix analyzer results in trace DAG #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @jorgeepc for the update, looks good |
xoscar
approved these changes
Jun 7, 2023
| import * as S from './SpanNode.styled'; | ||
|
|
||
| interface IProps extends NodeProps<INodeDataSpan> {} | ||
|
|
||
| const SpanNode = ({data, id, selected}: IProps) => { | ||
| const dispatch = useAppDispatch(); |
There was a problem hiding this comment.
We need to consider cleaning up nodes to not have to be connected to all of this state and such, maybe something to think latter on
There was a problem hiding this comment.
Yes, agree with that. I have been thinking about that for a while. We need to parse everything (span related) and inject it in the data object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes multiples fixes/improvements for the Trace Analyzer results in the DAG:
Analyzer errorscomponentAnalyzer errorscomponent and theSpan nodeChanges
Analyzer errorscomponentAnalyzer errorscomponent and theSpan nodeFixes
Checklist
Loom
https://www.loom.com/share/40bc665d8ec3484b9b168d8706666150