Replace abbreviations in collector config #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing all the abbreviations for tracetest and the data store vendors names with full names to make the docs more clear.
adnanrahic
approved these changes
Jun 6, 2023
docs/docs/examples-tutorials/recipes/running-tracetest-with-new-relic.md
Outdated
Show resolved
Hide resolved
…w-relic.md Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
jorgeepc
approved these changes
Jun 6, 2023
kdhamric
deleted the
change-abbreviation-of-datastore-names-to-use-full-names
branch
mathnogueira
pushed a commit
that referenced
this pull request
Jun 13, 2023
* Replace abbreviations in collector config Replacing all the abbreviations for tracetest and the data store vendors names with full names to make the docs more clear. * Update docs/docs/examples-tutorials/recipes/running-tracetest-with-new-relic.md Co-authored-by: Adnan Rahić <adnan@kubeshop.io> --------- Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing all the abbreviations for tracetest and the data store vendors names with full names to make the docs more clear.
We used the following in our collector configs:
tt for tracetest
nr for newrelic
hc for honeycomb
ls for lightstep
dd for datadog
This pr replaces the abbreviation with the full name. It helps make it clear what the different sections are as opposed to having users have to translate 'tt' into 'tracetest', hopefully making things more clear. This change was recommended by Alayshia at Honeycomb.