update(cli-e2e): Add e2e tests for the environment resource #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbdias
changed the title
xoscar
approved these changes
Jun 7, 2023
| @@ -222,6 +222,22 @@ func (resourceClient ResourceClient) List(ctx context.Context, listArgs ListArgs | |||
| return nil, fmt.Errorf("could not send request: %w", err) | |||
| } | |||
|
|
|||
| if resp.StatusCode == http.StatusBadRequest { | |||
There was a problem hiding this comment.
Definitely not the best but we can find a way to include better error handling across the CLI in the future!
mathnogueira
pushed a commit
that referenced
this pull request
Jun 13, 2023
* Update environment tests * Adding more tests to environment * Updating tests * Updating tests * Updating tests and documentation * Updating list tests * Adding more test cases * Updating test timeout to 5 min * Updating environment list pretty test * Adding more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our CLI e2e tests to test the environment resource in more verbs.
Loom: https://www.loom.com/share/3f191e460c83490ba1ddd5301e8016fd
Changes
Fixes
Checklist