Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fixing select spans visual bug #2698

Merged
merged 1 commit into from Jun 9, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Jun 9, 2023

This PR fixes a bug when displaying the switch span button while the test spec form is open that caused the prev checks to go out of bounds.

Changes

  • Updates container to have position absolute
  • Updates listener to wrap container

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test
Screenshot 2023-06-09 at 12 29 34

@xoscar xoscar added the frontend label Jun 9, 2023
@xoscar xoscar requested a review from jorgeepc June 9, 2023 18:29
@xoscar xoscar self-assigned this Jun 9, 2023
@xoscar xoscar linked an issue Jun 9, 2023 that may be closed by this pull request
@xoscar xoscar marked this pull request as ready for review June 9, 2023 18:29
@xoscar xoscar merged commit 81e6df1 into main Jun 9, 2023
24 checks passed
@xoscar xoscar deleted the 2492-fix-the-bug-with-select-a-current-span-behaviour branch June 9, 2023 19:05
mathnogueira pushed a commit that referenced this pull request Jun 13, 2023
fix(frontend): fixing select spans visual bue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix the bug with 'select a current span' behaviour
2 participants