Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(frontend): adding auto scroll to assertion result #2700

Merged
merged 1 commit into from Jun 9, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Jun 9, 2023

This PR adds a way to auto-scroll to any element in the UI and uses it for the assertion results

Changes

  • Assertion results content scrolls to result when selected span changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

https://www.loom.com/share/82c5917a28f14794b9b9914a7dc3c5bf

@xoscar xoscar linked an issue Jun 9, 2023 that may be closed by this pull request
@xoscar xoscar requested a review from jorgeepc June 9, 2023 19:04
@xoscar xoscar self-assigned this Jun 9, 2023
@xoscar xoscar added the frontend label Jun 9, 2023
@xoscar xoscar marked this pull request as ready for review June 9, 2023 19:04
Copy link
Contributor

@jorgeepc jorgeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@xoscar xoscar merged commit b588223 into main Jun 9, 2023
24 checks passed
@xoscar xoscar deleted the 2602-test-spec-detail-selections-improvements-1 branch June 9, 2023 21:17
mathnogueira pushed a commit that referenced this pull request Jun 13, 2023
feature(frontend): adding auto scroll to asseriton result
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Spec Detail selections Improvements
2 participants