fix(cli): remove cli analytics

.github/workflows/pull-request.yaml

@@ -30,7 +30,7 @@ jobs:
       - name: Setup go
         uses: actions/setup-go@v3
         with:
-          go-version-file: 'go.work'
+          go-version-file: "go.work"
           cache: true
           cache-dependency-path: go.work
       - name: install graph tool
@@ -65,7 +65,7 @@ jobs:
       - name: Setup go
         uses: actions/setup-go@v3
         with:
-          go-version-file: 'go.work'
+          go-version-file: "go.work"
           cache: true
           cache-dependency-path: go.work
       - name: Run unit tests
@@ -75,7 +75,7 @@ jobs:
     name: API Server unit tests
     runs-on: ubuntu-latest
 
-# git log --pretty=tformat:"%H" -n1 web
+    # git log --pretty=tformat:"%H" -n1 web
     steps:
       - name: Checkout
         uses: actions/checkout@v3
@@ -84,7 +84,7 @@ jobs:
       - name: Setup go
         uses: actions/setup-go@v3
         with:
-          go-version-file: 'go.work'
+          go-version-file: "go.work"
           cache: true
           cache-dependency-path: go.work
       - name: Run unit tests
@@ -181,7 +181,7 @@ jobs:
         if: steps.cache-docker-build.outputs.cache-hit != 'true'
         uses: actions/setup-go@v3
         with:
-          go-version-file: 'go.work'
+          go-version-file: "go.work"
           cache: true
           cache-dependency-path: go.work
       - uses: goreleaser/goreleaser-action@v4
@@ -208,7 +208,7 @@ jobs:
 
   test-examples:
     name: Test examples
-    needs:  [build-docker]
+    needs: [build-docker]
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
@@ -242,12 +242,12 @@ jobs:
 
           ./scripts/wait-for-port.sh 11633
 
-          ./dist/tracetest configure -g --endpoint http://localhost:11633 --analytics=false
+          ./dist/tracetest configure -g --endpoint http://localhost:11633
           ./dist/tracetest test run -d examples/${{ matrix.example_dir }}/tests/list-tests.yaml --wait-for-result || (cat /tmp/docker-log; exit 1)
 
   smoke-test-cli:
     name: CLI smoke tests
-    needs:  [build-docker]
+    needs: [build-docker]
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
@@ -314,7 +314,7 @@ jobs:
 
   e2e-cli:
     name: CLI e2e tests
-    needs:  [build-docker]
+    needs: [build-docker]
     runs-on: ubuntu-latest
     steps:
       - name: Checkout

cli/actions/configure_action.go

@@ -20,8 +20,7 @@ type ConfigureConfig struct {
 }
 
 type ConfigureConfigSetValues struct {
-	Endpoint         *string
-	AnalyticsEnabled *bool
+	Endpoint *string
 }
 
 type configureAction struct {
@@ -55,23 +54,14 @@ func (a configureAction) Run(ctx context.Context, args ConfigureConfig) error {
 		return err
 	}
 
-	var analyticsEnabled bool
-
-	if args.SetValues.AnalyticsEnabled != nil {
-		analyticsEnabled = *args.SetValues.AnalyticsEnabled
-	} else {
-		analyticsEnabled = ui.Confirm("Enable analytics?", true)
-	}
-
 	scheme, endpoint, err := config.ParseServerURL(serverURL)
 	if err != nil {
 		return err
 	}
 
 	config := config.Config{
-		Scheme:           scheme,
-		Endpoint:         endpoint,
-		AnalyticsEnabled: analyticsEnabled,
+		Scheme:   scheme,
+		Endpoint: endpoint,
 	}
 
 	err = a.saveConfiguration(ctx, config, args)

cli/analytics/analytics.go

@@ -1,88 +1,22 @@
 package analytics
 
 import (
-	"os"
-
 	"github.com/denisbrodbeck/machineid"
-	"github.com/kubeshop/tracetest/cli/config"
-	segment "github.com/segmentio/analytics-go/v3"
 )
 
 var (
-	SecretKey = ""
-	client    segment.Client
-	mid       string
+	mid string
 )
 
 func ClientID() string {
 	return mid
 }
 
-func Init(conf config.Config) {
-	if !conf.AnalyticsEnabled || os.Getenv("TRACETEST_DEV") != "" {
-		// non-empty TRACETEST_DEV variable means it's running by a dev,
-		// and we should totally ignore analytics
-		return
-	}
-
-	client, _ = segment.NewWithConfig(SecretKey, segment.Config{
-		BatchSize: 1,
-	})
-
+func Init() {
 	id, err := machineid.ProtectedID("tracetest")
 	if err == nil {
 		// only use id if available.
 		mid = id
 	} // ignore errors and continue with an empty ID if necessary
 
-	client.Enqueue(segment.Identify{
-		UserId: mid,
-		Traits: segment.NewTraits().
-			Set("source", "cli").
-			Set("clientID", mid).
-			Set("env", config.Env).
-			Set("appVersion", config.Version),
-		Context: &segment.Context{
-			Direct: true,
-		},
-	})
-}
-
-func Track(name, category string, props map[string]string) error {
-	if client == nil {
-		return nil
-	}
-
-	p := segment.NewProperties().
-		Set("source", "cli").
-		Set("clientID", mid).
-		Set("env", config.Env).
-		Set("appVersion", config.Version).
-		Set("category", category)
-
-	for k, v := range props {
-		p = p.Set(k, v)
-	}
-
-	err := client.Enqueue(segment.Track{
-		Event:      name,
-		UserId:     mid,
-		Properties: p,
-		Context: &segment.Context{
-			Direct: true,
-		},
-	})
-
-	return err
-}
-
-func Close() {
-	if client == nil {
-		return
-	}
-
-	err := client.Close()
-	if err != nil {
-		panic(err)
-	}
 }

cli/cmd/apply_cmd.go

@@ -6,7 +6,6 @@ import (
 	"strings"
 
 	"github.com/kubeshop/tracetest/cli/actions"
-	"github.com/kubeshop/tracetest/cli/analytics"
 	"github.com/kubeshop/tracetest/cli/formatters"
 	"github.com/kubeshop/tracetest/cli/parameters"
 	"github.com/spf13/cobra"
@@ -24,10 +23,6 @@ var applyCmd = &cobra.Command{
 		resourceType := args[0]
 		ctx := context.Background()
 
-		analytics.Track("Resource Apply", "cmd", map[string]string{
-			resourceType: resourceType,
-		})
-
 		resourceActions, err := resourceRegistry.Get(resourceType)
 
 		if err != nil {

cli/cmd/config.go

@@ -121,7 +121,7 @@ func setupCommand(options ...setupOption) func(cmd *cobra.Command, args []string
 			validateVersionMismatch()
 		}
 
-		analytics.Init(cliConfig)
+		analytics.Init()
 	}
 }
 
@@ -201,7 +201,6 @@ func setupLogger(cmd *cobra.Command, args []string) {
 
 func teardownCommand(cmd *cobra.Command, args []string) {
 	cliLogger.Sync()
-	analytics.Close()
 }
 
 func setupVersion() {

cli/cmd/configure_cmd.go

@@ -4,7 +4,6 @@ import (
 	"context"
 
 	"github.com/kubeshop/tracetest/cli/actions"
-	"github.com/kubeshop/tracetest/cli/analytics"
 	"github.com/kubeshop/tracetest/cli/parameters"
 	"github.com/kubeshop/tracetest/cli/utils"
 	"github.com/spf13/cobra"
@@ -19,8 +18,6 @@ var configureCmd = &cobra.Command{
 	Long:    "Configure your tracetest CLI",
 	PreRun:  setupLogger,
 	Run: WithResultHandler(WithParamsHandler(configParams)(func(cmd *cobra.Command, _ []string) (string, error) {
-		analytics.Track("Configure", "cmd", map[string]string{})
-
 		ctx := context.Background()
 		client := utils.GetAPIClient(cliConfig)
 		action := actions.NewConfigureAction(cliConfig, cliLogger, client)
@@ -34,10 +31,6 @@ var configureCmd = &cobra.Command{
 			actionConfig.SetValues.Endpoint = &configParams.Endpoint
 		}
 
-		if flagProvided(cmd, "analytics") {
-			actionConfig.SetValues.AnalyticsEnabled = &configParams.AnalyticsEnabled
-		}
-
 		err := action.Run(ctx, actionConfig)
 		return "", err
 	})),
@@ -51,6 +44,5 @@ func flagProvided(cmd *cobra.Command, name string) bool {
 func init() {
 	configureCmd.PersistentFlags().BoolVarP(&configParams.Global, "global", "g", false, "configuration will be saved in your home dir")
 	configureCmd.PersistentFlags().StringVarP(&configParams.Endpoint, "endpoint", "e", "", "set the value for the endpoint, so the CLI won't ask for this value")
-	configureCmd.PersistentFlags().BoolVarP(&configParams.AnalyticsEnabled, "analytics", "a", true, "configure the analytic state, so the CLI won't ask for this value")
 	rootCmd.AddCommand(configureCmd)
 }

cli/cmd/dashboard_cmd.go

@@ -3,7 +3,6 @@ package cmd
 import (
 	"fmt"
 
-	"github.com/kubeshop/tracetest/cli/analytics"
 	"github.com/kubeshop/tracetest/cli/utils"
 	"github.com/spf13/cobra"
 )
@@ -15,8 +14,6 @@ var dashboardCmd = &cobra.Command{
 	Long:    "Opens the Tracetest Dashboard URL",
 	PreRun:  setupCommand(),
 	Run: WithResultHandler(func(_ *cobra.Command, _ []string) (string, error) {
-		analytics.Track("Dashboard", "cmd", map[string]string{})
-
 		if cliConfig.IsEmpty() {
 			return "", fmt.Errorf("missing Tracetest endpoint configuration")
 		}

cli/cmd/delete_cmd.go

@@ -5,7 +5,6 @@ import (
 	"fmt"
 	"strings"
 
-	"github.com/kubeshop/tracetest/cli/analytics"
 	"github.com/kubeshop/tracetest/cli/parameters"
 	"github.com/spf13/cobra"
 )
@@ -22,10 +21,6 @@ var deleteCmd = &cobra.Command{
 		resourceType := args[0]
 		ctx := context.Background()
 
-		analytics.Track("Resource Delete", "cmd", map[string]string{
-			resourceType: resourceType,
-		})
-
 		resourceActions, err := resourceRegistry.Get(resourceType)
 		if err != nil {
 			return "", err

cli/cmd/export_cmd.go

@@ -5,7 +5,6 @@ import (
 	"fmt"
 	"strings"
 
-	"github.com/kubeshop/tracetest/cli/analytics"
 	"github.com/kubeshop/tracetest/cli/parameters"
 	"github.com/spf13/cobra"
 )
@@ -25,10 +24,6 @@ var exportCmd = &cobra.Command{
 		resourceType := args[0]
 		ctx := context.Background()
 
-		analytics.Track("Resource Export", "cmd", map[string]string{
-			resourceType: resourceType,
-		})
-
 		resourceActions, err := resourceRegistry.Get(resourceType)
 		if err != nil {
 			return "", err

cli/cmd/get_cmd.go

@@ -6,7 +6,6 @@ import (
 	"fmt"
 	"strings"
 
-	"github.com/kubeshop/tracetest/cli/analytics"
 	"github.com/kubeshop/tracetest/cli/formatters"
 	"github.com/kubeshop/tracetest/cli/parameters"
 	"github.com/kubeshop/tracetest/cli/utils"
@@ -25,10 +24,6 @@ var getCmd = &cobra.Command{
 		resourceType := args[0]
 		ctx := context.Background()
 
-		analytics.Track("Resource Get", "cmd", map[string]string{
-			resourceType: resourceType,
-		})
-
 		resourceActions, err := resourceRegistry.Get(resourceType)
 		if err != nil {
 			return "", err

cli/cmd/list_cmd.go

@@ -5,7 +5,6 @@ import (
 	"fmt"
 	"strings"
 
-	"github.com/kubeshop/tracetest/cli/analytics"
 	"github.com/kubeshop/tracetest/cli/formatters"
 	"github.com/kubeshop/tracetest/cli/parameters"
 	"github.com/kubeshop/tracetest/cli/utils"
@@ -24,10 +23,6 @@ var listCmd = &cobra.Command{
 		resourceType := args[0]
 		ctx := context.Background()
 
-		analytics.Track("Resource List", "cmd", map[string]string{
-			resourceType: resourceType,
-		})
-
 		resourceActions, err := resourceRegistry.Get(resourceType)
 		if err != nil {
 			return "", err

cli/cmd/server_install_cmd.go

@@ -1,7 +1,6 @@
 package cmd
 
 import (
-	"github.com/kubeshop/tracetest/cli/analytics"
 	"github.com/kubeshop/tracetest/cli/installer"
 	"github.com/kubeshop/tracetest/cli/parameters"
 	"github.com/spf13/cobra"
@@ -25,7 +24,6 @@ var serverInstallCmd = &cobra.Command{
 		installer.InstallationMode = installerParams.InstallationMode
 		installer.KubernetesContext = installerParams.KubernetesContext
 
-		analytics.Track("Server Install", "cmd", map[string]string{})
 		installer.Start()
 	},
 	PostRun: teardownCommand,