Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting running cli in docker #2724

Merged
merged 4 commits into from
Jun 14, 2023

Conversation

kdhamric
Copy link
Collaborator

Adding docs in two places per #2611 to document how to use the Tracetest image to run the CLI in docker without installing locally.

Documenting how to run the CLI inside of docker
Copy link
Member

@jfermi jfermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few editing suggestions.

kdhamric and others added 2 commits June 13, 2023 14:04
Co-authored-by: Julianne Fermi <julianne@kubeshop.io>
Co-authored-by: Julianne Fermi <julianne@kubeshop.io>
Copy link
Collaborator

@schoren schoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! might be easier to read if using host networking mode in docker, but that's a subjective opinion

Co-authored-by: Sebastian Choren <schoren@users.noreply.github.com>
@kdhamric kdhamric merged commit c4464c2 into main Jun 14, 2023
24 checks passed
@kdhamric kdhamric deleted the improve-ci-cd-by-including-docker-run-cmd branch June 14, 2023 20:02
mathnogueira pushed a commit that referenced this pull request Jun 19, 2023
* Documenting running cli in docker

Documenting how to run the CLI inside of docker

* Update docs/docs/ci-cd-automation/overview.md

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* Update docs/docs/cli/configuring-your-cli.md

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* Update docs/docs/cli/configuring-your-cli.md

Co-authored-by: Sebastian Choren <schoren@users.noreply.github.com>

---------

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>
Co-authored-by: Sebastian Choren <schoren@users.noreply.github.com>
mathnogueira pushed a commit that referenced this pull request Jun 19, 2023
* Documenting running cli in docker

Documenting how to run the CLI inside of docker

* Update docs/docs/ci-cd-automation/overview.md

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* Update docs/docs/cli/configuring-your-cli.md

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* Update docs/docs/cli/configuring-your-cli.md

Co-authored-by: Sebastian Choren <schoren@users.noreply.github.com>

---------

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>
Co-authored-by: Sebastian Choren <schoren@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants