feat(frontend): add errors filter and minor fixes for Analyzer results #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeepc
changed the title
jorgeepc
force-pushed
the
2647-analyzer-ui-improvements
branch
from
b7a1b61
to
1454674
Compare
jorgeepc
changed the title
xoscar
requested changes
Jun 14, 2023
| @@ -6,7 +6,7 @@ interface IProps { | |||
|
|
|||
| const CollapseIcon = ({isCollapsed}: IProps) => { | |||
| return ( | |||
| <S.CollapseIconContainer>{isCollapsed ? <S.DownCollapseIcon /> : <S.UpCollapseIcon />}</S.CollapseIconContainer> | |||
| <S.CollapseIconContainer>{isCollapsed ? <S.UpCollapseIcon /> : <S.DownCollapseIcon />}</S.CollapseIconContainer> | |||
|
|
||
| <S.StyledCollapse expandIcon={({isActive = false}) => <CollapseIcon isCollapsed={isActive} />}> | ||
| {plugins | ||
| .filter(plugin => !onlyErrors || plugin.score < MAX_SCORE) |
There was a problem hiding this comment.
Should we consider having a selector or service function that returns only the data we want to render? Instead of having the business logic at the component level?
There was a problem hiding this comment.
Yep, good one. Done!
| @@ -0,0 +1,25 @@ | |||
| import * as S from './AnalyzerScore.styled'; | |||
|
|
|||
There was a problem hiding this comment.
We'll have to move everything to analyzer from linter, bit by bit haha
xoscar
approved these changes
Jun 14, 2023
mathnogueira
pushed a commit
that referenced
this pull request
Jun 19, 2023
#2731) * feat(frontend): add errors filter for analyzer results and ux/ui improvements * add analyzer service
mathnogueira
pushed a commit
that referenced
this pull request
Jun 19, 2023
#2731) * feat(frontend): add errors filter for analyzer results and ux/ui improvements * add analyzer service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds multiple UX/UI improvements to the
TraceAnalyzerresult page.Changes
Fixes
Checklist
Loom
https://www.loom.com/share/f56e08c9b6f7490586abfb445d3005fe?sid=ca4367a3-ef43-454f-90e4-6ce80c83117e