Add observability to the rescue example #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is beautiful. 👌 |
danielbdias
changed the title
adnanrahic
reviewed
Jun 16, 2023
| # internal error! | ||
| ``` | ||
|
|
||
| ## Trace-based tests that you can run |
There was a problem hiding this comment.
Can you add a short description of what these two tests are doing?
Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
danielbdias
force-pushed
the
add/observability-to-the-rescue-example
branch
from
bc0e32f
to
d2acf6e
Compare
mathnogueira
approved these changes
Jun 16, 2023
Comment on lines
+22
to
+28
| # --- | ||
| # type: Analyzer | ||
| # spec: | ||
| # id: current | ||
| # name: Analyzer | ||
| # enabled: false | ||
| # minimumScore: 0 |
There was a problem hiding this comment.
Is there a reason for having this?
There was a problem hiding this comment.
It is because the Analyzer provisioning is broken for empty plugins. @xoscar solved it yesterday and as soon as we release a new version, I will uncomment this.
| type: Test | ||
| spec: | ||
| id: yWoVaiuVR | ||
| name: Your API call with error |
There was a problem hiding this comment.
What is the error in this case? All assertions are waiting 200 OK status.
There was a problem hiding this comment.
Maybe it's worth adding a description to the test to explain the usecase
There was a problem hiding this comment.
It makes sense to add a description. This is a test that is expected to fail, to simulate the problem that I'm presenting on the talk.
Context: https://www.loom.com/share/ab3579b2f5fa4fd4af58e088bcad8513?t=852&sid=2b4e5820-2e11-4e42-a9ae-08f33a594e36 (at the 14 min of the talk)
* add upsert method and enable it for environments * handle error when getting entity
mathnogueira
added a commit
that referenced
this pull request
Jun 19, 2023
* Adding initial APIs for the example * Adding code for payment-executor-api * Adding full example * Adding trace-based tests * Updating README * Apply suggestions from code review Co-authored-by: Adnan Rahić <adnan@kubeshop.io> * Adding documentation to the example * fix(backend): matching trigger span duration and trigger time durations (#2740) * fix(frontend): adding default value for data store connection types (#2742) * fix(backend): fixing response status code for grpc request (#2741) * feat: add upsert method and enable it for environments (#2746) * add upsert method and enable it for environments * handle error when getting entity * PR suggestions --------- Co-authored-by: Adnan Rahić <adnan@kubeshop.io> Co-authored-by: Oscar Reyes <oscar-rreyes1@hotmail.com> Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com>
mathnogueira
added a commit
that referenced
this pull request
Jun 19, 2023
* Adding initial APIs for the example * Adding code for payment-executor-api * Adding full example * Adding trace-based tests * Updating README * Apply suggestions from code review Co-authored-by: Adnan Rahić <adnan@kubeshop.io> * Adding documentation to the example * fix(backend): matching trigger span duration and trigger time durations (#2740) * fix(frontend): adding default value for data store connection types (#2742) * fix(backend): fixing response status code for grpc request (#2741) * feat: add upsert method and enable it for environments (#2746) * add upsert method and enable it for environments * handle error when getting entity * PR suggestions --------- Co-authored-by: Adnan Rahić <adnan@kubeshop.io> Co-authored-by: Oscar Reyes <oscar-rreyes1@hotmail.com> Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new example called "Observability to the Rescue! Monitoring and testing APIs with OpenTelemetry".
Loom: https://www.loom.com/share/9a5bdadfafc2417bb4534bb73487b0c6?sid=4116c7ed-5683-4bc6-8c31-deef4aadf896
Changes
Checklist