Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI e2e test for transaction resource #2757

Merged
merged 9 commits into from Jun 19, 2023

Conversation

danielbdias
Copy link
Contributor

@danielbdias danielbdias commented Jun 19, 2023

This PR adds CLI end to end tests for the transaction resource for the CRUD operations plus a simple run operation.
The bugs #2761 and 2760 will be handled in another PR, updating the respective tests.

Changes

  • Added e2e tests for get, apply, delete and list

Fixes

  • Formatting error for JSON output that was not marshalling transaction id.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@danielbdias danielbdias marked this pull request as ready for review June 19, 2023 18:49
@danielbdias danielbdias changed the title Add/cli e2e transaction test Add CLI e2e test for transaction resource Jun 19, 2023
Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@danielbdias danielbdias merged commit cf4c251 into main Jun 19, 2023
24 of 25 checks passed
@danielbdias danielbdias deleted the add/cli-e2e-transaction-test branch June 19, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants