Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(frontend): Automate Tab - CLI Command #2764

Merged
merged 8 commits into from
Jun 20, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Jun 19, 2023

This PR adds the CLI command controls and input for users to copy paste

Changes

  • Adds a new section to the automate tab
  • Incudes controls for the command
  • Updates code block component to use the same across the app

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

https://www.loom.com/share/f62bc225d38846b4af20d26d86255cd2

@xoscar xoscar self-assigned this Jun 19, 2023
@xoscar xoscar marked this pull request as ready for review June 19, 2023 23:02
@adnanrahic
Copy link
Contributor

This is awesome!

One suggestion might be cool:

  • Can we also enable naming the test definition file?
  • This could be a field in the left tile right above the code block.

My reasoning:

  • This would let the used give the test definition a specific name before downloading the file.
  • This would make the right tile use the specific name for the test definition from the left tile.

If this is too complex, I'm not super invested in having it. It's already pretty awesome!

Base automatically changed from feat/automate-tab-test-definition to feat/automate-tab June 20, 2023 16:12
@xoscar
Copy link
Collaborator Author

xoscar commented Jun 20, 2023

This is awesome!

One suggestion might be cool:

  • Can we also enable naming the test definition file?
  • This could be a field in the left tile right above the code block.

My reasoning:

  • This would let the used give the test definition a specific name before downloading the file.
  • This would make the right tile use the specific name for the test definition from the left tile.

If this is too complex, I'm not super invested in having it. It's already pretty awesome!

@adnanrahic great suggestion, can we create an issue for this and involve @olha23 so she can think about a design for this?

Copy link
Contributor

@jorgeepc jorgeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this 🔥 A couple of comments/questions.

  • I think we should have a Copy cmd button. It's not that clear that you have to click the code block to copy it.
  • Do we support yaml as an output for test run?

Comment on lines 13 to 14
<Switch onChange={onChange} checked={value} />
{text}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: here you can add an id to the switch component and a <label htmlFor="id">{text}</label>. With this you can use the switch by clicking on the text.

@xoscar xoscar merged commit ea42083 into feat/automate-tab Jun 20, 2023
1 check passed
@xoscar xoscar deleted the feat/automate-tab-cli-command branch June 20, 2023 17:43
xoscar added a commit that referenced this pull request Jun 20, 2023
* feature(frontend): Adding Automate Tab Skeleton (#2753)

* feature(frontend): Adding Automate Tab Skeleton

* cleanup

* feature(frontend): Automate Tab - Test Definition (#2763)

* feature(frontend): Adding Automate Tab Skeleton

* cleanup

* feature(frontend): Automate Tab - Test Definition

* feature(frontend): Automate Tab - CLI Command (#2764)

* feature(frontend): Adding Automate Tab Skeleton

* cleanup

* feature(frontend): Automate Tab - Test Definition

* feature(frontend): Automate Tab - CLI Command

* feature(frontend): UI cleanup

* feature(frontend): PR comments

* feature(frontend): Adding Automate Option for test runs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants