-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(frontend): Automate Tab - CLI Command #2764
Conversation
This is awesome! One suggestion might be cool:
My reasoning:
If this is too complex, I'm not super invested in having it. It's already pretty awesome! |
@adnanrahic great suggestion, can we create an issue for this and involve @olha23 so she can think about a design for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this 🔥 A couple of comments/questions.
- I think we should have a
Copy
cmd button. It's not that clear that you have to click the code block to copy it. - Do we support
yaml
as an output for test run?
<Switch onChange={onChange} checked={value} /> | ||
{text} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: here you can add an id
to the switch component and a <label htmlFor="id">{text}</label>
. With this you can use the switch by clicking on the text.
* feature(frontend): Adding Automate Tab Skeleton (#2753) * feature(frontend): Adding Automate Tab Skeleton * cleanup * feature(frontend): Automate Tab - Test Definition (#2763) * feature(frontend): Adding Automate Tab Skeleton * cleanup * feature(frontend): Automate Tab - Test Definition * feature(frontend): Automate Tab - CLI Command (#2764) * feature(frontend): Adding Automate Tab Skeleton * cleanup * feature(frontend): Automate Tab - Test Definition * feature(frontend): Automate Tab - CLI Command * feature(frontend): UI cleanup * feature(frontend): PR comments * feature(frontend): Adding Automate Option for test runs
This PR adds the CLI command controls and input for users to copy paste
Changes
Fixes
Checklist
https://www.loom.com/share/f62bc225d38846b4af20d26d86255cd2