-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(frontend): Automate Tab - Deep Link Technique #2791
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import * as S from './CodeBlock.styled'; | ||
import CodeBlock, {IProps as ICodeBlockProps} from './CodeBlock'; | ||
import useCopy from '../../hooks/useCopy'; | ||
|
||
interface IProps extends ICodeBlockProps { | ||
title: string; | ||
} | ||
|
||
const FramedCodeBlock = ({title, ...props}: IProps) => { | ||
const copy = useCopy(); | ||
|
||
return ( | ||
<S.FrameContainer> | ||
<S.FrameHeader> | ||
<S.FrameTitle>{title}</S.FrameTitle> | ||
<S.CopyButton ghost type="primary" onClick={() => copy(props.value)}> | ||
Copy | ||
</S.CopyButton> | ||
</S.FrameHeader> | ||
<CodeBlock {...props} /> | ||
</S.FrameContainer> | ||
); | ||
}; | ||
|
||
export default FramedCodeBlock; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,5 @@ | ||
import FramedCodeBlock from './FramedCodeBlock'; | ||
|
||
// eslint-disable-next-line no-restricted-exports | ||
export {default} from './CodeBlock'; | ||
export {FramedCodeBlock}; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,9 @@ | ||
import {useCallback} from 'react'; | ||
import {Button, Typography} from 'antd'; | ||
import SyntaxHighlighter from 'react-syntax-highlighter'; | ||
import {arduinoLight} from 'react-syntax-highlighter/dist/cjs/styles/hljs'; | ||
import {DownloadOutlined} from '@ant-design/icons'; | ||
import {downloadFile} from 'utils/Common'; | ||
import useCopy from 'hooks/useCopy'; | ||
|
||
import * as S from './FileViewerModal.styled'; | ||
import {FramedCodeBlock} from '../CodeBlock'; | ||
|
||
interface IProps { | ||
data: string; | ||
|
@@ -23,8 +20,6 @@ const FileViewerModal = ({data, isOpen, onClose, title, language = 'javascript', | |
downloadFile(data, fileName); | ||
}, [data, fileName]); | ||
|
||
const copy = useCopy(); | ||
|
||
const footer = ( | ||
<> | ||
<Button ghost onClick={onClose} type="primary" data-cy="file-viewer-close"> | ||
|
@@ -48,17 +43,9 @@ const FileViewerModal = ({data, isOpen, onClose, title, language = 'javascript', | |
width="70%" | ||
visible={isOpen} | ||
> | ||
<S.SubtitleContainer> | ||
<Typography.Text>{subtitle}</Typography.Text> | ||
</S.SubtitleContainer> | ||
<S.CodeContainer data-cy="file-viewer-code-container"> | ||
<S.CopyIconContainer onClick={() => copy(data)}> | ||
<S.CopyIcon /> | ||
</S.CopyIconContainer> | ||
<SyntaxHighlighter language={language} style={arduinoLight}> | ||
{data} | ||
</SyntaxHighlighter> | ||
</S.CodeContainer> | ||
<div data-cy="file-viewer-code-container"> | ||
<FramedCodeBlock title={subtitle} value={data} language={language} /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using new code block component |
||
</div> | ||
</S.FileViewerModal> | ||
); | ||
}; | ||
|
24 changes: 12 additions & 12 deletions
24
web/src/components/RunDetailAutomate/RunDetailAutomate.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,23 @@ | ||
import Test from 'models/Test.model'; | ||
import TestRun from 'models/TestRun.model'; | ||
import * as S from './RunDetailAutomate.styled'; | ||
import TestDefinition from '../RunDetailAutomateDefinition'; | ||
import RunDetailAutomateMethods from '../RunDetailAutomateMethods/RunDetailAutomateMethods'; | ||
|
||
interface IProps { | ||
test: Test; | ||
run: TestRun; | ||
} | ||
|
||
const RunDetailAutomate = ({test}: IProps) => { | ||
return ( | ||
<S.Container> | ||
<S.SectionLeft> | ||
<TestDefinition test={test} /> | ||
</S.SectionLeft> | ||
<S.SectionRight> | ||
<RunDetailAutomateMethods /> | ||
</S.SectionRight> | ||
</S.Container> | ||
); | ||
}; | ||
const RunDetailAutomate = ({test, run}: IProps) => ( | ||
<S.Container> | ||
<S.SectionLeft> | ||
<TestDefinition test={test} /> | ||
</S.SectionLeft> | ||
<S.SectionRight> | ||
<RunDetailAutomateMethods test={test} run={run} /> | ||
</S.SectionRight> | ||
</S.Container> | ||
); | ||
|
||
export default RunDetailAutomate; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used this exporting format here, I think we can think of moving to this version, but looking for suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!