chore(server): refactoring analyzer files to comply with resources standard

server/app/app.go

@@ -24,7 +24,7 @@ import (
 	httpServer "github.com/kubeshop/tracetest/server/http"
 	"github.com/kubeshop/tracetest/server/http/mappings"
 	"github.com/kubeshop/tracetest/server/http/websocket"
-	linterResource "github.com/kubeshop/tracetest/server/linter/resource"
+	analyzer "github.com/kubeshop/tracetest/server/linter/analyzer"
 	"github.com/kubeshop/tracetest/server/model"
 	"github.com/kubeshop/tracetest/server/openapi"
 	"github.com/kubeshop/tracetest/server/otlp"
@@ -197,7 +197,7 @@ func (app *App) Start(opts ...appOption) error {
 	pollingProfileRepo := pollingprofile.NewRepository(db)
 	dataStoreRepo := datastore.NewRepository(db)
 	environmentRepo := environment.NewRepository(db)
-	linterRepo := linterResource.NewRepository(db)
+	linterRepo := analyzer.NewRepository(db)
 
 	eventEmitter := executor.NewEventEmitter(testDB, subscriptionManager)
 	registerOtlpServer(app, testDB, eventEmitter, dataStoreRepo)
@@ -268,7 +268,7 @@ func (app *App) Start(opts ...appOption) error {
 	registerDemosResource(demoRepo, apiRouter, db, provisioner, tracer)
 
 	registerDataStoreResource(dataStoreRepo, apiRouter, db, provisioner, tracer)
-	registerlinterResource(linterRepo, apiRouter, db, provisioner, tracer)
+	registerAnalyzerResource(linterRepo, apiRouter, db, provisioner, tracer)
 
 	isTracetestDev := os.Getenv("TRACETEST_DEV") != ""
 	registerSPAHandler(router, app.cfg, configFromDB.IsAnalyticsEnabled(), serverID, isTracetestDev)
@@ -356,12 +356,12 @@ func registerOtlpServer(app *App, testDB model.Repository, eventEmitter executor
 	})
 }
 
-func registerlinterResource(linterRepo *linterResource.Repository, router *mux.Router, db *sql.DB, provisioner *provisioning.Provisioner, tracer trace.Tracer) {
-	manager := resourcemanager.New[linterResource.Linter](
-		linterResource.ResourceName,
-		linterResource.ResourceNamePlural,
+func registerAnalyzerResource(linterRepo *analyzer.Repository, router *mux.Router, db *sql.DB, provisioner *provisioning.Provisioner, tracer trace.Tracer) {
+	manager := resourcemanager.New[analyzer.Linter](
+		analyzer.ResourceName,
+		analyzer.ResourceNamePlural,
 		linterRepo,
-		resourcemanager.WithOperations(linterResource.Operations...),
+		resourcemanager.WithOperations(analyzer.Operations...),
 		resourcemanager.WithTracer(tracer),
 	)
 	manager.RegisterRoutes(router)

server/app/facade.go

@@ -8,7 +8,7 @@ import (
 	"github.com/kubeshop/tracetest/server/executor"
 	"github.com/kubeshop/tracetest/server/executor/pollingprofile"
 	"github.com/kubeshop/tracetest/server/executor/trigger"
-	linterResource "github.com/kubeshop/tracetest/server/linter/resource"
+	analyzer "github.com/kubeshop/tracetest/server/linter/analyzer"
 	"github.com/kubeshop/tracetest/server/model"
 	"github.com/kubeshop/tracetest/server/pkg/id"
 	"github.com/kubeshop/tracetest/server/subscription"
@@ -53,7 +53,7 @@ func (rf runnerFacade) RunAssertions(ctx context.Context, request executor.Asser
 func newRunnerFacades(
 	ppRepo *pollingprofile.Repository,
 	dsRepo *datastore.Repository,
-	lintRepo *linterResource.Repository,
+	lintRepo *analyzer.Repository,
 	testDB model.Repository,
 	transactionRunRepository *transaction.RunRepository,
 	appTracer trace.Tracer,

server/executor/linter_runner.go

@@ -8,7 +8,7 @@ import (
 
 	"github.com/kubeshop/tracetest/server/analytics"
 	"github.com/kubeshop/tracetest/server/linter"
-	linterResource "github.com/kubeshop/tracetest/server/linter/resource"
+	analyzerResource "github.com/kubeshop/tracetest/server/linter/analyzer"
 	"github.com/kubeshop/tracetest/server/model"
 	"github.com/kubeshop/tracetest/server/model/events"
 	"github.com/kubeshop/tracetest/server/subscription"
@@ -32,18 +32,18 @@ type LinterRunner interface {
 	WorkerPool
 }
 
-type LinterResourceGetter interface {
-	GetDefault(ctx context.Context) linterResource.Linter
+type AnalyzerGetter interface {
+	GetDefault(ctx context.Context) analyzerResource.Linter
 }
 
 type defaultlinterRunner struct {
-	updater              RunUpdater
-	inputChannel         chan LinterRequest
-	exitChannel          chan bool
-	subscriptionManager  *subscription.Manager
-	eventEmitter         EventEmitter
-	linterResourceGetter LinterResourceGetter
-	assertionRunner      AssertionRunner
+	updater             RunUpdater
+	inputChannel        chan LinterRequest
+	exitChannel         chan bool
+	subscriptionManager *subscription.Manager
+	eventEmitter        EventEmitter
+	analyzerGetter      AnalyzerGetter
+	assertionRunner     AssertionRunner
 }
 
 var _ WorkerPool = &defaultlinterRunner{}
@@ -54,15 +54,15 @@ func NewlinterRunner(
 	subscriptionManager *subscription.Manager,
 	eventEmitter EventEmitter,
 	assertionRunner AssertionRunner,
-	linterResourceGetter LinterResourceGetter,
+	analyzerGetter AnalyzerGetter,
 ) LinterRunner {
 	return &defaultlinterRunner{
-		updater:              updater,
-		inputChannel:         make(chan LinterRequest, 1),
-		subscriptionManager:  subscriptionManager,
-		eventEmitter:         eventEmitter,
-		assertionRunner:      assertionRunner,
-		linterResourceGetter: linterResourceGetter,
+		updater:             updater,
+		inputChannel:        make(chan LinterRequest, 1),
+		subscriptionManager: subscriptionManager,
+		eventEmitter:        eventEmitter,
+		assertionRunner:     assertionRunner,
+		analyzerGetter:      analyzerGetter,
 	}
 }
 
@@ -99,8 +99,8 @@ func (e *defaultlinterRunner) startWorker() {
 
 func (e *defaultlinterRunner) onRequest(request LinterRequest) {
 	ctx := request.Context()
-	lintResource := e.linterResourceGetter.GetDefault(ctx)
-	linter := linter.Newlinter(lintResource, linter.AvailablePlugins...)
+	lintResource := e.analyzerGetter.GetDefault(ctx)
+	linter := linter.NewLinter(lintResource, linter.AvailablePlugins...)
 
 	shouldSkip, reason := linter.ShouldSkip()
 	if shouldSkip {
@@ -153,7 +153,7 @@ func (e *defaultlinterRunner) onFinish(ctx context.Context, request LinterReques
 	e.assertionRunner.RunAssertions(ctx, assertionRequest)
 }
 
-func (e *defaultlinterRunner) onRun(ctx context.Context, request LinterRequest, linter linter.Linter, linterResource linterResource.Linter) (model.Run, error) {
+func (e *defaultlinterRunner) onRun(ctx context.Context, request LinterRequest, linter linter.Linter, analyzerResource analyzerResource.Linter) (model.Run, error) {
 	run := request.Run
 	log.Printf("[linterRunner] Test %s Run %d: Starting\n", request.Test.ID, request.Run.ID)
 
@@ -167,7 +167,7 @@ func (e *defaultlinterRunner) onRun(ctx context.Context, request LinterRequest,
 		return e.onError(ctx, request, run, err)
 	}
 
-	result.MinimumScore = linterResource.MinimumScore
+	result.MinimumScore = analyzerResource.MinimumScore
 	run = run.SuccessfulLinterExecution(result)
 	err = e.updater.Update(ctx, run)
 	if err != nil {

server/linter/resource/model.go → server/linter/analyzer/analyzer_entities.go

@@ -1,11 +1,23 @@
-package linter_resource
+package analyzer
 
 import (
 	"fmt"
 
 	"github.com/kubeshop/tracetest/server/pkg/id"
+	"github.com/kubeshop/tracetest/server/resourcemanager"
 )
 
+const (
+	ResourceName       = "Analyzer"
+	ResourceNamePlural = "Analyzers"
+)
+
+var Operations = []resourcemanager.Operation{
+	resourcemanager.OperationGet,
+	resourcemanager.OperationList,
+	resourcemanager.OperationUpdate,
+}
+
 type (
 	Linter struct {
 		ID           id.ID          `json:"id"`

server/linter/resource/manager.go → server/linter/analyzer/analyzer_repository.go

@@ -1,4 +1,4 @@
-package linter_resource
+package analyzer
 
 import (
 	"context"

server/linter/resource/manager_test.go → server/linter/analyzer/analyzer_repository_test.go

@@ -1,27 +1,27 @@
-package linter_resource_test
+package analyzer_test
 
 import (
 	"database/sql"
 	"testing"
 
 	"github.com/gorilla/mux"
-	linter_resource "github.com/kubeshop/tracetest/server/linter/resource"
+	analyzer "github.com/kubeshop/tracetest/server/linter/analyzer"
 	"github.com/kubeshop/tracetest/server/resourcemanager"
 	rmtests "github.com/kubeshop/tracetest/server/resourcemanager/testutil"
 )
 
 func TestlinterResource(t *testing.T) {
 	rmtests.TestResourceType(t, rmtests.ResourceTypeTest{
-		ResourceTypeSingular: linter_resource.ResourceName,
-		ResourceTypePlural:   linter_resource.ResourceNamePlural,
+		ResourceTypeSingular: analyzer.ResourceName,
+		ResourceTypePlural:   analyzer.ResourceNamePlural,
 		RegisterManagerFn: func(router *mux.Router, db *sql.DB) resourcemanager.Manager {
-			repo := linter_resource.NewRepository(db)
+			repo := analyzer.NewRepository(db)
 
-			manager := resourcemanager.New[linter_resource.Linter](
-				linter_resource.ResourceName,
-				linter_resource.ResourceNamePlural,
+			manager := resourcemanager.New[analyzer.Linter](
+				analyzer.ResourceName,
+				analyzer.ResourceNamePlural,
 				repo,
-				resourcemanager.WithOperations(linter_resource.Operations...),
+				resourcemanager.WithOperations(analyzer.Operations...),
 			)
 			manager.RegisterRoutes(router)
 

server/linter/resource/main_test.go → server/linter/analyzer/main_test.go

@@ -1,4 +1,4 @@
-package linter_resource_test
+package analyzer_test
 
 import (
 	"os"

server/linter/linter.go

@@ -4,10 +4,10 @@ import (
 	"context"
 	"fmt"
 
+	analyzer "github.com/kubeshop/tracetest/server/linter/analyzer"
 	linter_plugin_common "github.com/kubeshop/tracetest/server/linter/plugins/common"
 	linter_plugin_security "github.com/kubeshop/tracetest/server/linter/plugins/security"
 	linter_plugin_standards "github.com/kubeshop/tracetest/server/linter/plugins/standards"
-	linter_resource "github.com/kubeshop/tracetest/server/linter/resource"
 	"github.com/kubeshop/tracetest/server/model"
 )
 
@@ -27,10 +27,10 @@ type Linter interface {
 
 type linter struct {
 	plugins        []model.Plugin
-	linterResource linter_resource.Linter
+	linterResource analyzer.Linter
 }
 
-func Newlinter(linterResource linter_resource.Linter, plugins ...model.Plugin) linter {
+func NewLinter(linterResource analyzer.Linter, plugins ...model.Plugin) Linter {
 	return linter{plugins, linterResource}
 }