Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(frontend): Enabling Test Run Panels #2816

Merged
merged 4 commits into from Jun 26, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Jun 23, 2023

This PR enables multi-resizable panel support for the test run trace.
It allows the analyzer to be hidden.

Changes

  • Adds new Resizable Panels component
  • Updates trace and test layouts to use new panel system

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

https://www.loom.com/share/0fb7e4bde84e4bbaaef08110c8f51c5d

@xoscar xoscar requested a review from jorgeepc June 23, 2023 21:51
@xoscar xoscar self-assigned this Jun 23, 2023
@xoscar xoscar linked an issue Jun 23, 2023 that may be closed by this pull request
@xoscar xoscar marked this pull request as ready for review June 23, 2023 21:52
Copy link
Contributor

@jorgeepc jorgeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💣 Amazing work dude!

};

export const getAnalyzerPanel = (run: TestRun, order = 1): TPanel => ({
name: `ANALYZER_${order}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this order?

};

export const getSpanDetailsPanel = (testId: string, run: TestRun, order = 1): TPanel => ({
name: `SPAN_DETAILS_${order}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here for order

@@ -2,7 +2,6 @@ import React from 'react';
import ReactDOM from 'react-dom';
import * as Sentry from '@sentry/react';
import {BrowserTracing} from '@sentry/tracing';
import 'react-reflex/styles.css';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@xoscar xoscar merged commit d1149d0 into main Jun 26, 2023
25 checks passed
@xoscar xoscar deleted the 2794-add-ability-to-hide-analyzer-screen branch June 26, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to hide analyzer screen
2 participants