New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): post refactor cleanup #2843

Merged

schoren merged 3 commits into main from cli-cleanup

Jul 3, 2023

Collaborator

schoren commented Jun 30, 2023 •

edited

This PR cleans up so everything is consistent.

Removes now unused code, replaced by the new resourcemanager client.

formatters (except test, transactions and runs),
actions.Action interface and related implementations,
utils. ResourceClient and related code

removes the parameters package, and merges the code into cmd package, which is the only client.
each "parameter" struct from the parameters package is moved next to its consumer (i.e. parameters.ListParameters is now cmd.listParameters and lives in the list_cmd.go file where it is used)
unexports all structs that are only used locally

schoren added 3 commits

June 30, 2023 18:46


          cleanup

8f6a2f5


          Merge branch 'main' into cli-cleanup

cca8764


          fix cmd params

11b65ea

schoren requested review from mathnogueira and danielbdias and removed request for mathnogueira

July 3, 2023 18:01

danielbdias approved these changes

View reviewed changes

schoren merged commit 57ef16e into main

25 checks passed

schoren deleted the cli-cleanup branch

July 3, 2023 20:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment