Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): add analyzer errors by attribute #2846

Merged
merged 1 commit into from Jul 4, 2023

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Jul 3, 2023

This PR adds support to map the analyzer errors to span attributes. The idea is to have a behavior similar to test specs in the test tab, where you can see the errors per attribute in the AttributeList component.

Changes

  • Analyzer errors by attribute
  • New AnalyzerErrorsPopover component

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom

https://www.loom.com/share/3abbfdecf2fb46d1a74e7ecd9ec2945c?sid=9ab48319-9f01-4fdc-ab4e-7f31aa47bcaf

@jorgeepc jorgeepc self-assigned this Jul 3, 2023
@jorgeepc jorgeepc marked this pull request as ready for review July 3, 2023 21:57
@jorgeepc jorgeepc requested a review from xoscar July 3, 2023 21:57
@jorgeepc jorgeepc merged commit 6f8135a into main Jul 4, 2023
25 checks passed
@jorgeepc jorgeepc deleted the 2781-add-attribute-analyzer-error branch July 4, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Analyzer] UX - Attribute Level Feedback For Spans
2 participants