feature(frontend): Analyzer Configuration #2850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
commented
Jul 4, 2023
| @@ -32,14 +32,12 @@ const GlobalResult = ({score, minimumScore}: IProps) => { | |||
| <Percentage score={score} /> | |||
| </S.GlobalScoreContainer> | |||
| </S.GlobalScoreWrapper> | |||
| {!!minimumScore && ( | |||
There was a problem hiding this comment.
We should be always displaying this as per Olly's feedback
|
Hey @xoscar, amazing work! I watched your loom and have a couple of comments/questions:
|
|
A couple of findings:
|
schoren
approved these changes
Jul 4, 2023
Base automatically changed from
feat/analyzer-configuration-backend
to
feat/analyzer-configuration
July 5, 2023 18:51
xoscar
added a commit
that referenced
this pull request
Jul 10, 2023
* feature(backend): Enabling Analyzer Configuration (#2842) * feature: Enabling Analyzer Configuration * feature: Enabling Analyzer Configuration * cleanup and improvements * cleanup and improvements * improvements, upgrades and simplification * improvements, upgrades and simplification * adding tests for the analyzer and linter * fixing linter runner * updates and fixes based on PR review comments * removing unnecessary loop * feature(frontend): Analyzer Configuration (#2850) * feature: Enabling Analyzer Configuration * feature: Enabling Analyzer Configuration * cleanup and improvements * cleanup and improvements * improvements, upgrades and simplification * improvements, upgrades and simplification * adding tests for the analyzer and linter * fixing linter runner * feature(frontend): Analyzer Configuration * feature(frontend): Analyzer Configuration * updates and fixes based on PR review comments * clean up changes * fix(frontend): fix analyzer score styles (#2860) * feature(cli): Analyzer Configuration (#2873) * remove file with conflict * fix disabled rule logic --------- Co-authored-by: Jorge Padilla <jorge.esteban.padilla@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the analyzer configuration changes for the frontend, including the settings page and analyzer results
Changes
Fixes
Checklist
https://www.loom.com/share/f7b4e4e7fe1f46ada25ac3cda543c40e