Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): add select as current span in timeline #2851

Merged
merged 1 commit into from Jul 5, 2023

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Jul 4, 2023

This PR adds the select as current span feature to the Timeline visualization. We already had this feature as part of the Graph visualization, but we were missing it in our Timeline. We are refactoring a couple of components to be able to reuse the logic in both places.

Changes

  • refactor select as current span components and hook
  • implement select as current in timeline visualization

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom

https://www.loom.com/share/808d0d3bfdb147f78f626014a74a93f6?sid=c177ff95-5784-452b-92e7-28c340892bce

@jorgeepc jorgeepc self-assigned this Jul 4, 2023
@jorgeepc jorgeepc marked this pull request as ready for review July 4, 2023 21:47
@jorgeepc jorgeepc requested a review from xoscar July 4, 2023 21:49
Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clean 🧼 !

@jorgeepc jorgeepc merged commit 1111cd1 into main Jul 5, 2023
25 checks passed
@jorgeepc jorgeepc deleted the feat-select-as-current-span-timeline branch July 5, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants