Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): Add run verb #2885

Merged
merged 29 commits into from Jul 12, 2023
Merged

feat(cli): Add run verb #2885

merged 29 commits into from Jul 12, 2023

Conversation

schoren
Copy link
Collaborator

@schoren schoren commented Jul 7, 2023 •
edited

This PR implements the run verb

https://www.loom.com/share/2264bdd232d14087b4cbb7a0346cabf8

An error is returned when a non runnable resource is requested:
Screenshot 2023-07-10 at 21 22 46

running by id:
https://www.loom.com/share/629528673cb2451baf1a0314e4f12dfe

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@schoren schoren linked an issue Jul 10, 2023 that may be closed by this pull request
[CLI Improvements] Add run verb #2302
Closed
@schoren schoren marked this pull request as ready for review July 11, 2023 00:15
@schoren schoren requested review from danielbdias, mathnogueira and jorgeepc and removed request for danielbdias and mathnogueira July 11, 2023 00:15
danielbdias
danielbdias approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@danielbdias danielbdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! 😄
I've added some suggestions and comments, but nothing that could block this PR.

cli/cmd/config.go Outdated Show resolved Hide resolved
cli/cmd/resource_run_cmd.go Show resolved Hide resolved
cli/pkg/resourcemanager/apply.go Show resolved Hide resolved
cli/pkg/resourcemanager/apply.go Show resolved Hide resolved
cli/runner/transaction_runner.go Show resolved Hide resolved
testing/cli-e2etest/testscenarios/test/run_test_test.go Outdated Show resolved Hide resolved
cli/runner/orchestrator.go Show resolved Hide resolved
schoren and others added 2 commits July 12, 2023 15:22
@schoren @danielbdias
Update testing/cli-e2etest/testscenarios/test/run_test_test.go
67b9656 
Co-authored-by: Daniel Baptista Dias <danielbdias@users.noreply.github.com>
@schoren
fix typo
f869565
@schoren schoren merged commit 3eca8da into main Jul 12, 2023
25 checks passed
@schoren schoren deleted the add-run-verb branch July 12, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbdias danielbdias danielbdias approved these changes

@jorgeepc jorgeepc Awaiting requested review from jorgeepc

@mathnogueira mathnogueira Awaiting requested review from mathnogueira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CLI Improvements] Add run verb
2 participants
@schoren @danielbdias