feat: support span events #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add span events as an attribute called "events" * update attribute name to "span.events" * fix test
…gRPC and HTTP variants) (#2887) support events in jaeger and tempo (grpc and http)
* feat: support span events in app insights * don't ignore error and fix function names
xoscar
reviewed
Jul 11, 2023
| } | ||
| } | ||
|
|
||
| func withEvents(events []model.SpanEvent) option { |
There was a problem hiding this comment.
These types of mocking utils for spans and traces can be really useful for the entire test suite, in the future I think we should consider having them globally available
xoscar
approved these changes
Jul 11, 2023
* add docs and test in expression executor * Update docs/docs/cli/creating-test-specifications.md Co-authored-by: Julianne Fermi <julianne@kubeshop.io> --------- Co-authored-by: Julianne Fermi <julianne@kubeshop.io>
jorgeepc
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for span events as part of the span attributes
Checklist