Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fix analyzer config form for weight field #2925

Merged
merged 1 commit into from Jul 11, 2023

Conversation

jorgeepc
Copy link
Contributor

This PR fixes a parse issue that was causing an error when trying to update the rule's weight.

Changes

  • add normalize prop on rule weight input

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@jorgeepc jorgeepc self-assigned this Jul 11, 2023
@jorgeepc jorgeepc marked this pull request as ready for review July 11, 2023 21:41
@jorgeepc jorgeepc requested a review from xoscar July 11, 2023 21:42
<Form.Item
name={[fieldKey, 'weight']}
label="Weight input configuration"
normalize={value => parseInt(String(value ?? 0), 10)}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird, I thought I added this, not sure if it got lost 🤷🏾

@jorgeepc jorgeepc merged commit f8a2d11 into main Jul 11, 2023
25 checks passed
@jorgeepc jorgeepc deleted the fix-analyzer-config-weight branch July 11, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants