feature(frontend): Required Gates #2932
Conversation
| @@ -86,3 +85,5 @@ components: | |||
| type: integer | |||
| fail: | |||
| type: integer | |||
| allStepsRequiredGatesPassed: | |||
There was a problem hiding this comment.
This can be used by clients to validate if all the gates from the steps passed
I was going back and forth on having a full required gates result at the transaction level.
But I think transactions should not care about exactly which gates passed or not, just if the steps ran correctly
| @@ -407,5 +422,13 @@ func (td *RunRepository) readRunRow(row scanner) (TransactionRun, error) { | |||
| r.Fail = int(fail.Int32) | |||
| } | |||
|
|
|||
| // checks if the flag exists, if it doesn't we use the fail field to determine if all steps passed | |||
| if allStepsRequiredGatesPassed == nil { | |||
There was a problem hiding this comment.
If the value doesn't exist int the DB we can generate based on the fail count as it was the same result we used in the past
| state: TestRun['state']; | ||
| requiredGatesResult: RequiredGatesResult; | ||
| } | ||
|
|
There was a problem hiding this comment.
This component encapsulates the run status icon that should be used everywhere in the app
| @@ -0,0 +1,53 @@ | |||
| import {useCallback, useEffect} from 'react'; | |||
There was a problem hiding this comment.
Adding the settings form for the test runner options
| required, | ||
| failed, | ||
| passed, | ||
| requiredFailedGates: required.filter(gate => failed.includes(gate)), |
There was a problem hiding this comment.
Calculates the failed gates that are required from the model so we can use them elsewhere
| @@ -63,6 +64,15 @@ const ConfigEndpoint = (builder: TTestApiEndpointBuilder) => ({ | |||
| providesTags: () => [{type: TracetestApiTags.SETTING, id: ResourceType.AnalyzerType}], | |||
| transformResponse: (rawLinter: TRawLinter) => Linter(rawLinter), | |||
| }), | |||
| getTestRunner: builder.query<TestRunner, unknown>({ | |||
There was a problem hiding this comment.
I was thinking we can simplify the endpoints for settings and the overall resources, we can think about a clever way to handle that in the future
| <Typography.Text> | ||
| {ToTitle(gate)} <TooltipQuestion margin={6} title={SupportedRequiredGatesDescription[gate]} /> | ||
| </Typography.Text> |
There was a problem hiding this comment.
We could use a label here
| @@ -22,6 +22,7 @@ export const TRACE_DOCUMENTATION_URL = | |||
| export const ADD_TEST_URL = 'https://docs.tracetest.io/web-ui/creating-tests'; | |||
| export const ADD_TEST_OUTPUTS_DOCUMENTATION_URL = 'https://docs.tracetest.io/web-ui/creating-test-outputs'; | |||
| export const ANALYZER_DOCUMENTATION_URL = 'https://docs.tracetest.io/analyzer/concepts'; | |||
| export const TEST_RUNNER_DOCUMENTATION_URL = 'https://docs.tracetest.io/analyzer/concepts'; | |||
There was a problem hiding this comment.
Should we change this now?
| export const SupportedRequiredGatesDescription = { | ||
| [SupportedRequiredGates.AnalyzerScore]: 'Test Runs will be marked as failed if the Analyzer Score is below the configured threshold', | ||
| [SupportedRequiredGates.AnalyzerRules]: 'Test Runs will be marked as failed if the Error Level Analyzer Rules are not met', | ||
| [SupportedRequiredGates.TestSpecs]: 'Test Runs will be marked as failed if on of the defined Test Specs fail', |
There was a problem hiding this comment.
Test Runs will be marked as failed if one of ?
| @@ -63,6 +64,15 @@ const ConfigEndpoint = (builder: TTestApiEndpointBuilder) => ({ | |||
| providesTags: () => [{type: TracetestApiTags.SETTING, id: ResourceType.AnalyzerType}], | |||
| transformResponse: (rawLinter: TRawLinter) => Linter(rawLinter), | |||
| }), | |||
| getTestRunner: builder.query<TestRunner, unknown>({ | |||
* feature(backend): Required Gates (#2888) * feature(backend): Required Gates * adding tests and fixing bugs * adding tests and fixing bugs * addressing PR comments * addressing PR comments * updating go.modsum * feature(frontend): Required Gates (#2932) * feature(frontend): Test Runner Configuration * feature(frontend): cleanup * feature(frontend): removing unnecessary prop * feature(frontend): addressing PR review comments
This PR includes changes for the FE and backend to support the required gates feature
Changes
Fixes
Checklist
https://www.loom.com/share/2ef5aab0ed5d4ac6ac9c729efafab53d