Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backend) Updating Environment to Variable Set #3007

Merged

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Jul 31, 2023

This PR updates the backend to switch from environments to variable sets

Changes

  • Updates the database structure to match the new names
  • Changes the resource manager and logic around envs to use vars
  • Updates controller and other dependencies

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar xoscar added the backend label Jul 31, 2023
@xoscar xoscar self-assigned this Jul 31, 2023
@xoscar xoscar marked this pull request as ready for review July 31, 2023 15:45
Copy link
Contributor

@danielbdias danielbdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rename seems fine, but our e2e tests broke. Are you thinking of solving them on this PR later in another one?

api/openapi.yaml Outdated Show resolved Hide resolved
api/openapi.yaml Outdated Show resolved Hide resolved
api/openapi.yaml Outdated Show resolved Hide resolved
api/openapi.yaml Outdated Show resolved Hide resolved
api/openapi.yaml Outdated Show resolved Hide resolved
api/parameters.yaml Outdated Show resolved Hide resolved
api/variableSets.yaml Outdated Show resolved Hide resolved
@xoscar xoscar merged commit fdf1f43 into 3000-rename-environments-to-variables Aug 1, 2023
14 of 30 checks passed
@xoscar xoscar deleted the 3002-update-database-tables branch August 1, 2023 16:30
xoscar added a commit that referenced this pull request Aug 3, 2023
* chore(backend) Updating Environment to Variable Set (#3007)

* chore(backend) Updating Environment to Variable Set

* Updating open api

* chore(frotend): Updating Environment to Variable Set (#3012)

* chore(backend) Updating Environment to Variable Set

* chore(frotend): Updating Environment to Variable Set

* PR comments

* chore(cli): Adding support for Variable Sets (#3018)

* chore(cli): Adding support for Variable Sets

* chore(cli): Fixing automated tests

* chore(cli): Updating UI

* adding environment backwards compability and tests

* adding environment backwards compability and tests

* PR review update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants