feat: Adding var template support
#3053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
changed the title
var template support
danielbdias
approved these changes
Aug 10, 2023
server/expression/executor_test.go
Outdated
| ExpectedErrorMessage: `resolution error: environment variable "test" not found`, | ||
| ExpectedErrorMessage: `resolution error: variable "test" not found`, | ||
|
|
||
| EnvironmentDataStore: expression.EnvironmentDataStore{ |
There was a problem hiding this comment.
Should this attribute be VariableSetDataStore?
mathnogueira
requested changes
Aug 14, 2023
| @@ -99,5 +99,5 @@ func (ds EnvironmentDataStore) Get(name string) (string, error) { | |||
| } | |||
| } | |||
|
|
|||
| return "", fmt.Errorf(`environment variable "%s" not found`, name) | |||
| return "", fmt.Errorf(`variable "%s" not found`, name) | |||
There was a problem hiding this comment.
We should rename the EnvironmentDataStore to VariableSetDataStore or something similar
There was a problem hiding this comment.
Done! Do you mind retaking a look?
mathnogueira
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the app to support the
varkeyword as part of triggers and test specsChanges
varenvFixes
Checklist
https://www.loom.com/share/a9d1958fe876417a9d38e42c4788878a