Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed to utilize the embedded Tracetest #3057

Merged
merged 4 commits into from Aug 11, 2023
Merged

Conversation

kdhamric
Copy link
Collaborator

With Tracetest now included in the OpenTelemetry Demo repo, this change utilizes it for the recipe.

This PR...

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

With Tracetest now included in the OpenTelemetry Demo repo, this change utilizes it for the recipe.
Copy link
Contributor

@adnanrahic adnanrahic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just added some suggestions for typos.

docs/docs/live-examples/opentelemetry-store/overview.md Outdated Show resolved Hide resolved
docs/docs/live-examples/opentelemetry-store/overview.md Outdated Show resolved Hide resolved
docs/docs/live-examples/opentelemetry-store/overview.md Outdated Show resolved Hide resolved
kdhamric and others added 3 commits August 11, 2023 08:00
Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
@kdhamric kdhamric merged commit 7882f45 into main Aug 11, 2023
30 checks passed
@kdhamric kdhamric deleted the otel-demo-recipe-update branch August 11, 2023 14:15
danielbdias pushed a commit that referenced this pull request Aug 11, 2023
* Changed to utilize the embedded Tracetest

With Tracetest now included in the OpenTelemetry Demo repo, this change utilizes it for the recipe.

* Update docs/docs/live-examples/opentelemetry-store/overview.md

Co-authored-by: Adnan Rahić <adnan@kubeshop.io>

* Update docs/docs/live-examples/opentelemetry-store/overview.md

Co-authored-by: Adnan Rahić <adnan@kubeshop.io>

* Update docs/docs/live-examples/opentelemetry-store/overview.md

Co-authored-by: Adnan Rahić <adnan@kubeshop.io>

---------

Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants