fix(ui): kafka trigger with null header blocks test render on WebUI #3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
reviewed
Aug 16, 2023
web/src/models/KafkaRequest.model.ts
Outdated
| @@ -19,6 +19,10 @@ const KafkaRequest = ({ | |||
| messageKey = '', | |||
| messageValue = '', | |||
| }: TRawKafkaRequest): KafkaRequest => { | |||
| if (!headers) { | |||
There was a problem hiding this comment.
We try to avoid side effects like this, I think it is better to have something like
headers: !headers ? [] : ...
There was a problem hiding this comment.
It makes sense. I've updated this code to something similar, using the notation (headers || []) when building the model:
headers: (headers || []).map(({key = '', value = ''}) => ({
xoscar
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a UI bug caused by tests with Kafka trigger and no headers.
Loom: https://www.loom.com/share/f246f488f58d4aefa2fe34a67bb6b6e4?sid=8753e331-70b6-4462-92a5-b1116ed0c23a
Changes
demodeployChecklist