Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(server): split trigger worker into 3 workers #3120

Merged
merged 7 commits into from
Sep 5, 2023
Merged

chore(server): split trigger worker into 3 workers #3120

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0431fc8
chore(server): split trigger worker into 3 workers
mathnogueira Sep 4, 2023
2cf9274
rename runner file and delete unit test
mathnogueira Sep 4, 2023
85a11a4
fix test
mathnogueira Sep 4, 2023
238ef63
fix(trigger-worker): trace-id injection
mathnogueira Sep 5, 2023
f96c25a
address sebastian's comment
mathnogueira Sep 5, 2023
51346e3
fix: instrumentation
mathnogueira Sep 5, 2023
7f24134
Merge branch 'main' of github.com:kubeshop/tracetest into feat/split-…
mathnogueira Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 17 additions & 3 deletions server/app/test_pipeline.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,16 +68,28 @@ func buildTestPipeline(
eventEmitter,
)

runner := executor.NewPersistentRunner(
triggerResolverWorker := executor.NewTriggerResolverWorker(
triggerRegistry,
execTestUpdater,
tracer,
subscriptionManager,
tracedbFactory,
dsRepo,
eventEmitter,
)

triggerExecuterWorker := executor.NewTriggerExecuterWorker(
triggerRegistry,
execTestUpdater,
tracer,
eventEmitter,
)

triggerResultProcessorWorker := executor.NewTriggerResultProcessorWorker(
tracer,
subscriptionManager,
eventEmitter,
)

cancelRunHandlerFn := executor.HandleRunCancelation(execTestUpdater, tracer, eventEmitter)

queueBuilder := executor.NewQueueBuilder().
Expand All @@ -92,7 +104,9 @@ func buildTestPipeline(
pgQueue := executor.NewPostgresQueueDriver(pool)

pipeline := executor.NewPipeline(queueBuilder,
executor.PipelineStep{Processor: runner, Driver: pgQueue.Channel("runner")},
executor.PipelineStep{Processor: triggerResolverWorker, Driver: pgQueue.Channel("trigger_resolve")},
executor.PipelineStep{Processor: triggerExecuterWorker, Driver: pgQueue.Channel("trigger_execute")},
executor.PipelineStep{Processor: triggerResultProcessorWorker, Driver: pgQueue.Channel("trigger_result")},
executor.PipelineStep{Processor: tracePoller, Driver: pgQueue.Channel("tracePoller")},
executor.PipelineStep{Processor: linterRunner, Driver: pgQueue.Channel("linterRunner")},
executor.PipelineStep{Processor: assertionRunner, Driver: pgQueue.Channel("assertionRunner")},
Expand Down
2 changes: 1 addition & 1 deletion server/executor/poller_executor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ func getRunRepositoryMock(t *testing.T) *testdb.MockRepository {

testDB := new(testdb.MockRepository)
testDB.Test(t)
testDB.On("CreateTestRunEvent", mock.Anything).Return(noError)
testDB.On("CreateTestRunEvent", mock.Anything).Return(nil)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this the same? noError is a pretty name for a nil error IIRC


return testDB
}
Expand Down
303 changes: 0 additions & 303 deletions server/executor/runner.go
View file
Open in desktop

This file was deleted.