-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): cleanup and dynamic endpoint support #3121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One question, are we protecting the Configure cmd with the flag, or is not needed?
|
||
environmentClient = resourcemanager.NewClient( | ||
httpClient, cliLogger, | ||
"env", "environments", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is env
correct here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if we use envrionment it collides with the other resource 🥴
* feature(cli): Adding CLI cloud login and auth logic (#3100) * feature(cli): adding CLI cloud login and auth logic * feature(cli): adding CLI cloud login and auth logic * feat(cloud): adding support for cloud resources (#3101) * feature(cli): adding CLI cloud login and auth logic * feature(cli): adding CLI cloud login and auth logic * feat(cloud): adding support for cloud resources * feat(cloud): adding select command for cloud resources * feat(cloud): Tracetest configure improvements (#3102) * feature(cli): adding CLI cloud login and auth logic * feature(cli): adding CLI cloud login and auth logic * feat(cloud): adding support for cloud resources * feat(cloud): adding select command for cloud resources * fixing CLI e2e * Fixing missing prefix and CLI e2e tests * removing deprecation tests for environments * downgrading the goreleaser version * fixing CLI e2e * fixing status code * fixing FE port * fixing FE port * Implementing tracetest configure command * cleanup * adding missing select cmd * adding path validation for configure * re adding missing tests * feat(cli): adding `tracetest start` command (#3114) * feat(cli): adding start command * feat(cli): adding start command * feat(cli): cleanup and dynamic endpoint support (#3121)
This PR...
Changes
Fixes
Checklist
https://www.loom.com/share/650c1c542a734e8c962e9300526f8958