Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): Start command cleanup #3183

Merged
merged 2 commits into from Sep 25, 2023
Merged

chore(cli): Start command cleanup #3183

merged 2 commits into from Sep 25, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Sep 25, 2023

This PR removes the usage of the tracetest dev flag to make it work
Removes the select command
Updates the start command to be part of the configure group

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar xoscar self-assigned this Sep 25, 2023
@xoscar xoscar marked this pull request as ready for review September 25, 2023 19:57
@xoscar xoscar merged commit 3dbaff5 into main Sep 25, 2023
38 checks passed
@xoscar xoscar deleted the chore/cli-start-cleanup branch September 25, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

@danielbdias danielbdias danielbdias approved these changes

@schoren schoren Awaiting requested review from schoren

@mathnogueira mathnogueira Awaiting requested review from mathnogueira

Assignees

@xoscar xoscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xoscar @jorgeepc @danielbdias