Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Check if Agent API flag exists first #3206

Merged
merged 2 commits into from Oct 3, 2023
Merged

fix(cli): Check if Agent API flag exists first #3206

merged 2 commits into from Oct 3, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Oct 3, 2023

This PR fixes an issue when switching between named and local mode where the agent API key wasn't used as the primary auth method.

Changes

  • Moves the agent API key check before the jwt

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar xoscar self-assigned this Oct 3, 2023
@xoscar xoscar marked this pull request as ready for review October 3, 2023 17:33
@xoscar xoscar merged commit e0e6390 into main Oct 3, 2023
38 checks passed
@xoscar xoscar deleted the fix/agent-api-key branch October 3, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

@schoren schoren Awaiting requested review from schoren

@mathnogueira mathnogueira Awaiting requested review from mathnogueira

@danielbdias danielbdias Awaiting requested review from danielbdias

Assignees

@xoscar xoscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xoscar @jorgeepc