feat: report metrics about the test pipeline queues #3213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathnogueira
commented
Oct 3, 2023
Comment on lines
+88
to
+90
| q.enqueueCounter.Add(ctx, 1, metric.WithAttributes( | ||
| attribute.String("queue.name", q.name), | ||
| )) |
There was a problem hiding this comment.
Is there any other information available at this moment that we should include in the metric attributes?
mathnogueira
requested review from
schoren,
danielbdias,
xoscar and
jorgeepc
and removed request for
schoren and
danielbdias
mathnogueira
commented
Oct 3, 2023
Comment on lines
+55
to
+57
| if namedDriver, ok := driver.(namedDriver); ok { | ||
| queue.name = namedDriver.Name() | ||
| } |
There was a problem hiding this comment.
This was the way I found to be able to populate the queue name from the postgresQueueDriver channel.
6 tasks
mathnogueira
changed the title
xoscar
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds metrics about the queues in our test pipeline
Checklist
Loom video
https://www.loom.com/share/a316ac8b97a6462a9513fafba8d0101d
Screenshot