Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: metrics of pipeline steps #3217

Merged
merged 2 commits into from Oct 4, 2023
Merged

feat: metrics of pipeline steps #3217

merged 2 commits into from Oct 4, 2023

Conversation

mathnogueira
Copy link
Member

@mathnogueira mathnogueira commented Oct 4, 2023

This PR adds metrics to the pipeline steps containing data about the test run, and test id.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

https://www.loom.com/share/83fb22b1d66c427197b1955f88148995

@mathnogueira mathnogueira requested review from schoren, danielbdias, jorgeepc and xoscar and removed request for schoren October 4, 2023 19:03
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/metric"
)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this middleware approach

@mathnogueira mathnogueira merged commit 0c94f68 into main Oct 4, 2023
38 checks passed
@mathnogueira mathnogueira deleted the feat/workers-metrics branch October 4, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants