Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): OAuth process #3224

Merged
merged 1 commit into from Oct 6, 2023
Merged

fix(cli): OAuth process #3224

merged 1 commit into from Oct 6, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Oct 6, 2023

This PR updates the OAuth behavior to use redirects instead of AJAX request, the initial request should contain a return URL which will point to the UI

Changes

  • Adds redirect behavior
  • Removes JSON response

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

@xoscar xoscar self-assigned this Oct 6, 2023
@xoscar xoscar requested a review from jorgeepc October 6, 2023 18:56
@xoscar xoscar marked this pull request as ready for review October 6, 2023 18:57
@xoscar xoscar merged commit 3ff92f1 into main Oct 6, 2023
38 checks passed
@xoscar xoscar deleted the fix/oauth-process branch October 6, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

Assignees

@xoscar xoscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xoscar @jorgeepc