Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use histogram to keep track of request counts #3240

Merged
merged 2 commits into from Oct 11, 2023
Merged

fix: use histogram to keep track of request counts #3240

merged 2 commits into from Oct 11, 2023

Conversation

mathnogueira
Copy link
Member

@mathnogueira mathnogueira commented Oct 11, 2023 •
edited

This PR fixes all counter metrics. It uses a histogram instead of the metric.Counter which is accumulative over time

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

Add your loom video here if your work can be visualized

@mathnogueira mathnogueira requested review from schoren, xoscar and danielbdias and removed request for schoren October 11, 2023 18:50
@mathnogueira mathnogueira merged commit ad07ca4 into main Oct 11, 2023
38 checks passed
@mathnogueira mathnogueira deleted the fix/counter-metrics branch October 11, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoscar xoscar xoscar approved these changes

@danielbdias danielbdias danielbdias approved these changes

@schoren schoren Awaiting requested review from schoren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mathnogueira @xoscar @danielbdias