Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): UX Improvements #3251

Merged
merged 1 commit into from Oct 12, 2023
Merged

chore(cli): UX Improvements #3251

merged 1 commit into from Oct 12, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Oct 12, 2023

This PR updates a couple of things regarding the tracetest start command to show better messaging and remove some of the things we don't need

Changes

  • Adds start message to inform the user what we are trying to accomplish
  • Removes log messages from agent workers
  • Fixes stop agent logic (again 馃ゴ )

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

https://www.loom.com/share/8bb1e837317c4641ac2795ae47e0ff9c

@xoscar xoscar self-assigned this Oct 12, 2023
@xoscar xoscar marked this pull request as ready for review October 12, 2023 17:51
@xoscar xoscar merged commit feee677 into main Oct 12, 2023
38 checks passed
@xoscar xoscar deleted the chore/cli-improvements branch October 12, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

@mathnogueira mathnogueira Awaiting requested review from mathnogueira

@schoren schoren Awaiting requested review from schoren

Assignees

@xoscar xoscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xoscar @jorgeepc