chore(cli): Adding otlp server error handling #3252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeepc
approved these changes
Oct 12, 2023
cli/pkg/starter/starter.go
Outdated
| session, err = initialization.Start(ctx, cfg) | ||
| if err != nil && errors.Is(err, initialization.ErrOtlpServerStart) { | ||
| s.ui.Error("Tracetest Agent binds to the OpenTelemetry ports 4317 and 4318 which are used to receive trace information from your system. The agent tried to bind to these ports, but failed.") | ||
| shouldRetry := s.ui.Enter("Please stop the process currently listening on these ports and enter to try again.") |
There was a problem hiding this comment.
maybe we can improve the message: ...and press enter to try again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the error message when the ports for the OTLP server are not available to be more descriptive instead of just the default error
Changes
Fixes
Checklist
Loom video
https://www.loom.com/share/4660f8bbbb0441e492cba69b73aa7e05