New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): panic on concurrent read write #3253

Merged

schoren merged 1 commit into main from fix-cache-concurrent-readwrite

Oct 12, 2023

Collaborator

schoren commented Oct 12, 2023 •

edited

This PR adds mutex locks to prevent a concurrent map read/write on spans cache.
I hit this issue a few times but it's hard to reproduce

Checklist

tested locally
added new dependencies
updated the docs
added a test


          fix(server): panic on concurrent read write

8037e72

schoren requested a review from mathnogueira

October 12, 2023 18:42

xoscar approved these changes

View reviewed changes

jorgeepc approved these changes

View reviewed changes

schoren merged commit 187959a into main

38 checks passed

schoren deleted the fix-cache-concurrent-readwrite branch

October 12, 2023 19:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment